%time now hugely broken in sagenb-0.7.4 (sage-4.3.2)

[williamstein]

On Tue, Feb 9, 2010 at 1:22 PM, finotti <luis.finotti@gmail.com> wrote:
> Dear all,
>
> Cells starting with "%time" stopped working with 4.3.2.  (It works
> with 4.3.1.)  Is it no long supported or is it a bug? (time still
> works with the command line.)
>
> Running on Linux 32-bit, ubuntu binary.
>
> Thanks,

Wow, what a horrible, horrible regression! Indeed, I've confirmed that what happens is that doing %time causes the notebook to hang forever, and be pretty broken thereafter. Ouch. The issue was reported at these sage-support and sage-notebook threads.

Component: notebook

Author: Mitesh Patel

Reviewer: William Stein

Merged: sagenb-0.7.5.3

Issue created by migration from https://trac.sagemath.org/ticket/8225

[sagetrac-mvngu]

Description changed:

--- 
+++ 
@@ -13,4 +13,4 @@
 >
 > Thanks,
 ```
-Wow, what a horrible, horrible regression!   Indeed, I've confirmed that what happens is that doing %time causes the notebook to hang forever, and be pretty broken thereafter.   Ouch. 
+Wow, what a horrible, horrible regression!   Indeed, I've confirmed that what happens is that doing %time causes the notebook to hang forever, and be pretty broken thereafter.   Ouch. The issue was reported at these [sage-support](http://groups.google.com/group/sage-support/browse_frm/thread/354b7d759e48a326) and [sage-notebook](http://groups.google.com/group/sage-notebook/browse_frm/thread/aaa9d029f57e372c) threads.

[qed777]

Attachment: trac_8225-timeit_notebook.patch.gz

Fix %time and %timeit. sagenb repo.

[dandrake]

comment:3

I can confirm that this patch fixes the problem with %time on 4.3.3, and %timeit also works, but doesn't work as it does on the command line -- there, %timeit runs multiple loops and so on. Is that how %timeit has always worked in the notebook?

I don't know this particular code very well, but the patch appears to fix the problem and seems okay. So consider this a quite weak positive review.

[qed777]

comment:4

I think %timeit has worked that way in the notebook. See this sage-devel thread. The worksheet I mentioned is now here.

[mwhansen]

Reviewer: William Stein

[mwhansen]

Author: Mitesh Patel