-
-
Couldn't load subscription status.
- Fork 684
Migrate bliss extension to meson #38836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nto meson-compile
… into meson-compile
|
After thinking more about this, I don't see the point of these modularized distributions. Meson is now able to selectively build the bliss-part of sage depending on whether bliss is installed or not. Thus a separate module where bliss is marked as required seems to be rather pointless to me. I guess the only advantage would be shipping a binary wheel that includes bliss, but that could also easily be done as part of the main project. In summary: if someone wants to continue here, please feel free to do so. @dimpase @orlitzky if you want to create a giac package, you can take this PR here as a blueprint. @kwankyu The "Build and Test" are failing without any error message. I had this in a couple of PRs, mostly when there are compilation errors. This is rather inconvenient. Could you please fix this (My understanding is that you are one of the very few that understand the CI infrastructure)? |
|
@tobiasdiez - I agree. I am busy with the move now, till next week. |
|
I only see the value if they are moved to a separate repository, but there are now many more important things to do, like move all of the |
That's easy to do. If you tell me what you want to disable, then I can prepare a PR. (Btw, meson caches its dependency checks - at least if they provide pkgconfig data.) |
If this would allow us to get rid of the |
|
One example is ffmpeg. It is occasionally installed on the user's machine, but if they build sage with In the interim what I imagine is three levels of feature support: yes, no, and maybe. If the user builds with Having any sort of runtime detection is undesirable, but in this example it's nice for binary distros and users who don't want to rebuild all of sagelib just to pick up |
|
This makes a lot of sense. I would wait, however, with implementing this until we have faded out the old setuptools-based build and only use meson. Otherwise we have to implement many workarounds since we cannot rely on the build system to check for things during build time. |
WIP
Follow-up to #36524.
📝 Checklist
⌛ Dependencies