Make libsingular multivariate polynomial rings collectible #39628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 7b99647; changes) is ready! 🎉 |
5 tasks
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 24, 2025
sagemathgh-40814: Rerun plural and singular/function on failure This pull request: * add new feature `--all-except` to `sage -t` (does what you expect) * modify `ci-meson.yml` to workaround sagemath#29528 , the cause of which is yet unknown. (I also tried porting an old pull request that purportedly fix the issue at sagemath#39628, but the result is even worse.) controlling this in bash seems easier than sagemath#39539 , for now. I suspect testing these files separately will make it stop failing however (doesn't really matter, the bug remains). sagemath#40729 (comment) contains a traceback, but I think it isn't of too much help. (Thought? Is `--all --exclude=a --exclude=b` better?) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40814 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2025
sagemathgh-40814: Rerun plural and singular/function on failure This pull request: * add new feature `--all-except` to `sage -t` (does what you expect) * modify `ci-meson.yml` to workaround sagemath#29528 , the cause of which is yet unknown. (I also tried porting an old pull request that purportedly fix the issue at sagemath#39628, but the result is even worse.) controlling this in bash seems easier than sagemath#39539 , for now. I suspect testing these files separately will make it stop failing however (doesn't really matter, the bug remains). sagemath#40729 (comment) contains a traceback, but I think it isn't of too much help. (Thought? Is `--all --exclude=a --exclude=b` better?) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40814 Reported by: user202729 Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive #13447 . (Doesn't work yet.)
(Should) fix #29528 .
The commit is not mine, but author information is lost from the squashing of commits and I haven't figured out how to fix it yet.
I don't really understand how it work either (at the moment), to be figured out.
Looks like there's a frustrating segmentation fault that, again, cannot be debugged when run under gdb… (exactly as before…) it looks like triggering the bug requires an exact number of objects to be present, which makes it so that deleting some test below the segmentation fault point can hide the bug.
📝 Checklist
⌛ Dependencies