Add back ubuntu-noble-standard to ci-linux #40157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue with one of the runs (as explained above, it works some of the time. Maybe at least half) The first error is non-critical since (supposedly) by design it will just retry with 10.6 after 10.7 doesn't exist. See |
tscrim
approved these changes
May 27, 2025
There was a problem hiding this comment.
I'm going to approve this since you're saying that it will likely fix the CI failures that are happening on so many PRs. However, I don't have much knowledge in this area.
I am cc-ing @tobiasdiez and @dimpase in case they have any thoughts/knowledge on this (including if there is someone else who is good to cc).
|
Also cc-ing @tornaria and @antonio-rojas too. |
Are all of these runs from the same code? The failing runs seem to be failing for different reasons. I'm fine with readding this; hopefully it will work and indeed fix the linked issue. |
Slightly different, but the code difference appears to be irrelevant to the error difference. Each run takes > 2 hours (!!!) so I really don't want to look too hard into it. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40157: Add back ubuntu-noble-standard to ci-linux Fixes sagemath#40120 — I believe. As explained there, the root cause is that `ci-linux.yml` no longer build from scratch on `ubuntu-noble-standard` to generate the base docker image for the incremental builds to base on. In any case this appears to be harmless enough. From some [testing](https://github.com/user202729/sage/actions/workflows/ci- linux.yml) this works _some_ of the time (the debug statements are harmless)… which is not great, but the **current** `standard` runs aren't completely reliable either. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40157 Reported by: user202729 Reviewer(s): Travis Scrimshaw
5 tasks
|
okay, new release. The build succeeded this time. https://github.com/sagemath/sage/actions/runs/15379005941/job/43267361858#step:15:60 hope it works? |
|
It seems to work well. Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40120 — I believe.
As explained there, the root cause is that
ci-linux.ymlno longer build from scratch onubuntu-noble-standardto generate the base docker image for the incremental builds to base on.In any case this appears to be harmless enough.
From some testing this works some of the time (the debug statements are harmless)… which is not great, but the current
standardruns aren't completely reliable either.📝 Checklist
⌛ Dependencies