remove unset TERM when initializing non-interactive sage
#40495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pwntools was supposedly fixed! See Gallopsled/pwntools#1658 In any case, this is sensible if the CI is green. No user-facing scripts should be messing with |
|
I can still reproduce the bug with the latest versions of pwntools and sage. |
|
@vbraun how do we approve the CI for first-time contributors? |
|
There is an "Approve workflow to run" button |
not for me :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sage unsets the environment variable
TERM, which disables colored output by default. This behavior also causes error for packages that depend oncurses.setuptermbecausecurses.setuptermraises an error whenTERMis unset.pwntoolsis also affected by this issue. #39334 3-manifolds/Sage_macOS#78The original issue #12263 is 13 years ago and has been resolved since python 3.5.
📝 Checklist
⌛ Dependencies