better error message in magma_free when timeout #41041
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit d68e75f; changes) is ready! 🎉 |
|
@fchapoton The fix looks good to me. However, in addition to fixing the error message, it should be also mentioned in the documentation for
without saying what would happen when time is out. |
|
can I set to positive review ? |
|
@fchapoton Looks good, thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 18, 2025
sagemathgh-41041: better error message in magma_free when timeout fix sagemath#38430 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41041 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 19, 2025
sagemathgh-41041: better error message in magma_free when timeout fix sagemath#38430 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41041 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2025
sagemathgh-41041: better error message in magma_free when timeout fix sagemath#38430 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41041 Reported by: Frédéric Chapoton Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #38430
📝 Checklist