png attachment links broken

[mkoeppe]

To be investigated whether the actual files are accessible.

In any case, this will have to be fixed post-migration.

[kwankyu]

Can I see the affected issues in the preview repo: https://github.com/sagemath/sage-migration-preview-2023-02-02?

[mkoeppe]

No, but I have just made the next iteration public, where you can see it for example in https://github.com/sagemath/sage-migration-preview-2023-02-04/issues/10146: the png attachment gives "not found", but the other attached file (technically a repository_file) works.

[mkoeppe]

(Note that sagemath/sage is at the moment a redirect to https://github.com/sagemath/sage-migration-preview-2023-02-04)

[kwankyu]

Did the importer drop all .png attachments?

[mkoeppe]

It did not report anything regarding the .png attachments.

It did report (as expected) that a number of large (> 25MB) attachments were "not found" (= dropped in the process).

[kwankyu]

There's no problem here:

https://github.com/sagemath/sage-migration-preview-2023-02-04/issues/25270
(this is now sagemath/sage#25270)

[mkoeppe]

hm, interesting!

[mkoeppe]

OK, so the link in the description has been rewritten to a correct one.
But the link in https://github.com/sagemath/sage-migration-preview-2023-02-04/issues/25270#comment:1 is also broken (not rewritten to the actual storage location).
(this is now sagemath/sage#25270 (comment))

[kwankyu]

Here works too:

https://github.com/sagemath/sage-migration-preview-2023-02-04/issues/34113
(this is now sagemath/sage#34113)

[kwankyu]

Perhaps the image attachment should have been linked as https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#images in attachment comment ?

[mkoeppe]

Yes, that would likely have fixed it.

[kwankyu]

I think it's okay to reschedule the final import once again, if it is hard to fix after migration.

[mkoeppe]

No, I'd rather not delay it further. I think it's easy to fix afterwards using PyGithub (REST API). Easier than #110, which requires use of a more complicated API (GraphQL)

[kwankyu]

Okay.

BTW, if we use the markdown syntax, then the image will show up again in the attachment comment.

[mkoeppe]

Right, that's not really intended.