chore: upgrade django 4.2 LTS (@W-14178534) #148
Conversation
|
Would you mind adding to the CHANGELOG.md? |
|
Testing with our service often uncovers problems with DDA changes that the unit tests don't. I'll leave it to you if you want to go ahead and merge this change or wait until you do that testing. |
bgrant
left a comment
bgrant
left a comment
There was a problem hiding this comment.
Can you add a line to the CHANGELOG.md?
| - [PR 144](https://github.com/salesforce/django-declarative-apis/pull/141) Allow Dependabot to update dev dependencies | ||
| - [PR 143](https://github.com/salesforce/django-declarative-apis/pull/143) Testing: Replace `flake8` and `black` with `ruff`, add testing for Python 3.12, drop testing for Python 3.7 | ||
| - [PR 146](https://github.com/salesforce/django-declarative-apis/pull/146) Add ExpandableGeneric filter type | ||
| - [PR 148](https://github.com/salesforce/django-declarative-apis/pull/148) chore: upgrade django 4.2 LTS (@W-14178534) |
There was a problem hiding this comment.
Thank you for adding this.
It looks like we forgot to update this CHANGELOG the last time we released DDA. This release contains the "ExpandableGeneric" filter type (and I assume the PRs before it):
Release Django Declarative APIs v0.31.6 · salesforce/django-declarative-apis
This isn't your mistake, but would you mind fixing the CHANGELOG?
There was a problem hiding this comment.
You could potentially fix it in the PR when you make a release, so I'll go ahead and approve this PR.
bgrant
left a comment
bgrant
left a comment
There was a problem hiding this comment.
I found an issue with the CHANGELOG. Would you mind fixing it when you update the CHANGELOG as part of making a new release?
will do, to save time i'll merge this and fix the changelog with the release PR. |
pyproject.tomlpip installsucceeds with a clean virtualenv