fix BoundEndpointManager get_response saves #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @dshafer is an internal user so signing the CLA is not required. However, we need to confirm this. |
bgrant
reviewed
Mar 31, 2022
| from .utils import locate_object, rate_limit_exceeded | ||
|
|
||
| try: | ||
| from dirtyfields.dirtyfields import reset_state |
Collaborator
There was a problem hiding this comment.
What does this do? I don't see it used anywhere.
Collaborator
Author
There was a problem hiding this comment.
ahh can be removed; I missed it. Originally I thought that the manager update_or_create method wouldn't manage the dirty state properly, but it turns out that it does
bgrant
reviewed
Mar 31, 2022
| class _TestResource: | ||
| def is_dirty(self, check_relationship=False): | ||
| return True | ||
| class _TestEndpoint1(machinery.EndpointDefinition): |
Collaborator
There was a problem hiding this comment.
Thanks for fixing the tests
bgrant
added a commit
that referenced
this pull request
May 2, 2022
* fix BoundEndpointManager get_response saves * Remove unused code Co-authored-by: Robert David Grant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.