Prepare for 64-bit positions #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not add 64-bit position support, it just ensures bcftools will build without warnings (using gcc/clang -Wall) when built against both 32-bit and 64-bit position branches of HTSlib. Makes various printf()s use PRId64 for positions. The values are cast to (int64_t) so both 32-bit and 64-bit versions work.
valeriuo
approved these changes
Sep 18, 2019
Contributor
valeriuo
left a comment
valeriuo
left a comment
There was a problem hiding this comment.
It needs to be rebased and the switch to 64 bit types be applied to the latest changes in develop.
Member
|
Thank you for this |
Member
Author
|
Thanks for merging, but unfortunately you were a bit too quick here, as two more fixes need to be added due to changes in bcftools since this was originally written. Would you mind if I push in another commit to add them? |
Member
|
Of course, sorry. I can revert if you want, but a separate commit is good too. |
Member
Author
|
No need to revert, the problem is now fixed via c17a908 |
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not add 64-bit position support, it just ensures bcftools will build without warnings (using gcc/clang -Wall) when built against both 32-bit and 64-bit position branches of HTSlib.
Makes various printf()s use PRId64 for positions. The values are cast to (int64_t) so both 32-bit and 64-bit versions work.