Skip to content

Conversation

@marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Apr 26, 2024

@ja9fuchs Lets review it together next week when you are available.

This PR adds new feature: Simple Mount scenario for ASCS ERS cluster.

Changes:

  1. Simple Mount added as separate task, enabled by as default ASCS cluster for SUSE, disabled for Red Hat and marked as TODO when SAPStartSrv agent is available. Controlled by variable sap_ha_pacemaker_cluster_nwas_abap_ascs_ers_simple_mount
  2. Added more variables for cluster resources and updated naming to align with previous changes: variables for order, colocation and groups.
  3. Added IS_ERS parameter, which is valid for all 3 scenarios.
  4. New entry for SAPStartSrv in resource agent dictionary __sap_ha_pacemaker_cluster_resource_agents

Requirement: Simple mount uses shared NFS for both ASCS and ERS data across both nodes, sap_storage_setup role has to be executed for both NFS entries on both servers by changing input in AP4S dictionary:

      sap_storage_setup_host_type:
        - nwas_abap_ascs
        - nwas_abap_ers

sap_storage_setup vars in AP4S need to be adjusted as well to use actual variables from var files, instead of lookup based on hostname:

        sap_storage_setup_nwas_abap_ascs_instance_nr: "{{ sap_system_nwas_abap_ascs_instance_nr }}"
        sap_storage_setup_nwas_abap_ers_instance_nr: "{{ sap_system_nwas_abap_ers_instance_nr }}"

Example of cluster with Simple Mount

Node List:
  * Online: [ ae1ascs ae1ers ]

Full List of Resources:
  * rsc_fence_aws       (stonith:external/ec2):  Started ae1ascs
  * Resource Group: grp_AE1_ASCS00:
    * rsc_vip_AE1_ASCS00        (ocf::heartbeat:aws-vpc-move-ip):        Started ae1ascs
    * rsc_SAPStartSrv_AE1_ASCS00        (ocf::suse:SAPStartSrv):         Started ae1ascs
    * rsc_SAPInstance_AE1_ASCS00        (ocf::heartbeat:SAPInstance):    Started ae1ascs
  * Resource Group: grp_AE1_ERS10:
    * rsc_vip_AE1_ERS10 (ocf::heartbeat:aws-vpc-move-ip):        Started ae1ers
    * rsc_SAPStartSrv_AE1_ERS10 (ocf::suse:SAPStartSrv):         Started ae1ers
    * rsc_SAPInstance_AE1_ERS10 (ocf::heartbeat:SAPInstance):    Started ae1ers

@marcelmamula marcelmamula added the enhancement New feature or request label Apr 26, 2024
@marcelmamula marcelmamula requested a review from ja9fuchs April 26, 2024 11:17
@marcelmamula marcelmamula self-assigned this Apr 26, 2024
@marcelmamula
Copy link
Contributor Author

@ja9fuchs New post steps were added to ensure that cluster is in stable state after HAlib implementation as it was doing changes on running resources without proper restart so sapcontrol functions were not returning proper values.

It differentiates between Simple mount and classic, restarting SAPStartSrv or SAPInstance.

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looking good with the improved HA validation 👍

@marcelmamula marcelmamula merged commit ef06363 into sap-linuxlab:dev Jun 5, 2024
@marcelmamula marcelmamula deleted the simple-mount branch July 2, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants