Skip to content

Conversation

@rainerleber
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #12 (d857df4) into main (f980073) will decrease coverage by 3.45%.
The diff coverage is 64.77%.

❗ Current head d857df4 differs from pull request most recent head 9e1f908. Consider uploading reports for the commit 9e1f908 to get more accurate results

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   80.87%   77.41%   -3.46%     
==========================================
  Files          19       21       +2     
  Lines        1307     1395      +88     
  Branches      169      179      +10     
==========================================
+ Hits         1057     1080      +23     
- Misses        190      245      +55     
- Partials       60       70      +10     
Flag Coverage Δ
sanity ?
units 77.34% <64.77%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/system/sap_pyrfc.py 44.64% <44.64%> (ø)
...ests/unit/plugins/modules/system/test_sap_pyrfc.py 100.00% <100.00%> (ø)
plugins/modules/system/sap_task_list_execute.py 61.95% <0.00%> (-8.70%) ⬇️
plugins/modules/system/sapcontrol.py 72.15% <0.00%> (-6.33%) ⬇️
plugins/modules/system/sap_snote.py 76.19% <0.00%> (-5.96%) ⬇️
plugins/modules/identity/sap_company.py 83.72% <0.00%> (-5.82%) ⬇️
plugins/modules/database/saphana/hana_query.py 70.49% <0.00%> (-3.28%) ⬇️
plugins/modules/identity/sap_user.py 71.08% <0.00%> (-3.02%) ⬇️
plugins/modules/files/sapcar_extract.py 51.13% <0.00%> (-2.28%) ⬇️
plugins/modules/system/sap_system_facts.py 67.03% <0.00%> (-2.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link

@rkpobe rkpobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bis auf die paar Anmerkungen ist mir nichts aufgefallen....

Copy link

@rkpobe rkpobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@rainerleber rainerleber merged commit cad3449 into sap-linuxlab:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants