Skip to content

Conversation

marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Sep 23, 2025

Premise

CI Action provided by Ansible team must be executed and passing in order to mark our collection as maintained and in good shape.

Changes

  • GitHub workflow CI was updated:

    • Triggers updated
    • Comments were added for clarity
    • Ansible and Python matrix updated
    • Split steps into Supported (current versions) and EOL (with continue-on-error: true) to track backwards compatibility without enforcing it.
    • Sanity tests updated:
      • Ansible and Python matrix updated
  • ignore files added for current ansible versions and devel.

  • Python 2 compatibility was removed

  • All detected issues in tests were fixed.

  • Readme was updated to reflect tested versions and to note Python 2 compatibility removal.

Tests

Tests were done by CI workflow in question.

@mariolenz
Copy link
Contributor

Apropos of nothing, how about dropping support for ansible-core < 2.17 and do a new major release? I mean, even 2.16 is already EOL. Incidentally, 2.17 and onward don't support Python 2 at all anymore. This might make some things easier for you.

BTW you might also want to update meta/runtime.yml:

---
requires_ansible: ">=2.9.10"

2.9 is pretty old. But some people might say that dropping 2.9 means a new major version. Hence my suggestion to drop even more old and outdated ansible-core versions while you're at it 😏

Just an idea...

cc @felixfontein

@marcelmamula marcelmamula changed the title workflow: Fix errors from ansible-test action - WIP workflow: Fix errors from ansible-test action - #2 Sep 24, 2025
@marcelmamula marcelmamula changed the title workflow: Fix errors from ansible-test action - #2 workflow: Fix errors from ansible-test action WIP Sep 24, 2025
@marcelmamula
Copy link
Contributor Author

@mariolenz @felixfontein I removed Python 2 from tests and it is in alignment of dropped Python 2 support across our whole SAP LinuxLab project.

If we set minimum at 2.17, then it would still be good to know if older are working.
Do you have any experience with splitting action to run non-EOL and EOL as separate step, where EOL would have continue-on-error: true? It might work to show in future when compatibility breaks.

I will be updating Readme (explain dropped support for pyrfc) and other files as well so it would be bump to 1.5.0 version.

@berndfinger
Copy link
Member

I will be updating Readme (explain dropped support for pyrfc) and other files as well so it would be bump to 1.5.0 version.

Fine for me, thanks @marcelmamula !

@marcelmamula marcelmamula changed the title workflow: Fix errors from ansible-test action WIP workflow: Update ansible-test CI action and fix detected issues Sep 25, 2025
@marcelmamula marcelmamula self-assigned this Sep 25, 2025
@marcelmamula marcelmamula added the enhancement New feature or request label Sep 25, 2025
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula merged commit 7d590bf into sap-linuxlab:dev Sep 25, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants