-
Notifications
You must be signed in to change notification settings - Fork 9
workflow: Update ansible-test CI action and fix detected issues #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apropos of nothing, how about dropping support for ansible-core < 2.17 and do a new major release? I mean, even 2.16 is already EOL. Incidentally, 2.17 and onward don't support Python 2 at all anymore. This might make some things easier for you. BTW you might also want to update meta/runtime.yml: community.sap_libs/meta/runtime.yml Lines 1 to 2 in 226181d
2.9 is pretty old. But some people might say that dropping 2.9 means a new major version. Hence my suggestion to drop even more old and outdated ansible-core versions while you're at it 😏 Just an idea... |
@mariolenz @felixfontein I removed Python 2 from tests and it is in alignment of dropped Python 2 support across our whole SAP LinuxLab project. If we set minimum at 2.17, then it would still be good to know if older are working. I will be updating Readme (explain dropped support for |
Fine for me, thanks @marcelmamula ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Premise
CI Action provided by Ansible team must be executed and passing in order to mark our collection as maintained and in good shape.
Changes
GitHub workflow
CI
was updated:continue-on-error: true
) to track backwards compatibility without enforcing it.ignore files added for current ansible versions and devel.
Python 2 compatibility was removed
All detected issues in tests were fixed.
Readme was updated to reflect tested versions and to note Python 2 compatibility removal.
Tests
Tests were done by CI workflow in question.
Successful run for supported and EOL https://github.com/sap-linuxlab/community.sap_libs/actions/runs/18001651979
Successful run for supported versions with EOL Sanity failed https://github.com/sap-linuxlab/community.sap_libs/actions/runs/18001396453/job/51211443590
continue-on-error: true