Detected template "X && X". Logical operator has equal expressions

[VladimirPlyashkun]

Hi, there is a bug in the ast.cpp:796 file. Conditional block has logical and operator with same operands.

if (lhs_tail->head() && !rhs_tail->head()) return false;
if (!lhs_tail->head() && rhs_tail->head()) return false;
if (lhs_tail->head() && lhs_tail->head()) {   // <--- here:  lhs_tail->head()
    if (!lhs_tail->head()->is_superselector_of(rhs_tail->head())) return false;
}

I suppose, that correct code should look like this:

if (lhs_tail->head() && !rhs_tail->head()) return false;
if (!lhs_tail->head() && rhs_tail->head()) return false;
if (lhs_tail->head() && rhs_tail->head()) {
    if (!lhs_tail->head()->is_superselector_of(rhs_tail->head())) return false;
}

[saper]

Thanks. Fortunately this has no impact (since lhs_tail->head() != 0 implies rhs_tail->head() != 0 in conjunction with the two lines above, but definitely worth fixing, which I did in #1744