Skip to content

Simplify autotools build #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Simplify autotools build #992

merged 1 commit into from
Mar 27, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Mar 27, 2015

  • Generate sass_version.h
  • Use $(EXEEXT) for executables
  • No need for -lm and C++ library.
  • They should be provided by libtool.

Work done by @saper !

@mgreter mgreter self-assigned this Mar 27, 2015
@mgreter mgreter added this to the 3.2 milestone Mar 27, 2015
Generate sass_version.h
Use $(EXEEXT) for executables
No need for -lm and C++ library.
They should be provided by libtool.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.37% when pulling 3ffa142 on mgreter:dlopen into cfce077 on sass:master.

mgreter added a commit that referenced this pull request Mar 27, 2015
Simplify autotools build
@mgreter mgreter merged commit b287d31 into sass:master Mar 27, 2015
@saper
Copy link
Member

saper commented Mar 28, 2015

Can we also have AM_PROG_AR on mingw32? Otherwise autoreconf complains out:

/usr/local/share/automake-1.15/am/ltlibrary.am: warning: 'libsass.la': linking libtool libraries using a non-POSIX
/usr/local/share/automake-1.15/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
Makefile.am:28:   while processing Libtool library 'libsass.la'

@saper
Copy link
Member

saper commented Mar 28, 2015

Looks like _AC_PROG_CC_G autoconf test sets -O2 -g as the default compiler flags on gcc-likes (including clang).

@drewwells
Copy link
Contributor

just as a sanity check, b/c this has been changing a lot lately. Here's the params I pass to build libsass

-lsass -lsdc++ -lm -ldl -std=c++11

lm is removed by this PR and I think ldl was removed in another. Which of these params should I be passing now?

@saper
Copy link
Member

saper commented Mar 28, 2015

Can you try running autoreconf and then ./configure ? libtool should find them

@mgreter mgreter deleted the dlopen branch April 6, 2015 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants