Allow project-specific CommentCreator taking into account the existing header #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Sorry to ask, but what would be the exact effect of this change? |
|
Of course! The main change is that this unseals Additionally, it adds a This can be used to make sure the copyright year is preserved. I can provide a crude regex-based implementation of that as a unit test, though doing it 'really correctly' might be hard so I'm not proposing adding such an implementation to the plugin itself just yet :). |
Via HeaderCreator and CommentCreator
|
Nice! |
krchniam
pushed a commit
to krchniam/sbt-header
that referenced
this pull request
Jul 2, 2018
…g header (sbt#142) * Allow taking into account the existing header when adding a new one * Add test preserving copyright year Via HeaderCreator and CommentCreator * Add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be used to implement #23
Just a sketch for feedback, if the general approach looks OK I'll add tests and look more closely at binary compatibility.