Avoid forcing evaluation of crypto #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `val crypto` in the package object means that when it's undefined an exception is thrown immediately, which makes it impossible to use the WebCrypto facade in such a case. An example situation where this is preventative is using the WebCrypto API from Node where its available as a library and not globally available.
|
+1! I had this exact problem in http4s/http4s#4938. FWIW, I think the WebCrypto facade should be its own module without any reference to DOM if possible, to maximize cross-compatibility. But not important here :) |
armanbilge
approved these changes
Aug 8, 2021
|
For scalajs-dom 2.x, even better is to use an |
|
Merged as this is already approved, thanks @armanbilge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
val cryptoin the package object means that when it's undefinedan exception is thrown immediately, which makes it impossible to use the
WebCrypto facade in such a case.
An example situation where this is preventative is using the WebCrypto
API from Node where its available as a library and not globally
available.