Skip to content

Fix erasure for classOf[Unit], don't erase to classOf[BoxedUnit] #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2016
Merged

Fix erasure for classOf[Unit], don't erase to classOf[BoxedUnit] #5094

merged 1 commit into from
Apr 28, 2016

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Apr 11, 2016

No description provided.

@scala-jenkins scala-jenkins added this to the 2.12.0-M5 milestone Apr 11, 2016
@lrytz lrytz mentioned this pull request Apr 11, 2016
Merged
@sjrd
Copy link
Member

sjrd commented Apr 11, 2016

Thanks!

@lrytz
Copy link
Member Author

lrytz commented Apr 12, 2016

review by @adriaanm - follow-up for #5059

@adriaanm adriaanm self-assigned this Apr 26, 2016
@adriaanm
Copy link
Contributor

LGTM -- Lukas reminded me void.type is a thing on Java, which explains the special case.

@adriaanm adriaanm merged commit 11dac0f into scala:2.12.x Apr 28, 2016
@lrytz lrytz deleted the classOfUnit branch May 17, 2016 13:37
@adriaanm adriaanm added 2.12 and removed 2.12 labels Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adriaanm adriaanm

Labels

None yet

Projects

None yet

Milestone

2.12.0-M5

Development

Successfully merging this pull request may close these issues.

4 participants

@lrytz @sjrd @adriaanm @scala-jenkins