Fix bugs in RemoteLinksTests #13200
Merged
Fix bugs in RemoteLinksTests #13200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
force-pushed
the
scaladoc/link-test-fixes
branch
2 times, most recently
from
d135edd to
010302a
Compare
romanowski
requested review from
nicolasstucki
and removed request for
nicolasstucki
romanowski
force-pushed
the
scaladoc/link-test-fixes
branch
from
010302a to
16d4450
Compare
|
I somehow messed-up my branches. It should be good now, sorry! |
dwijnand
reviewed
Jul 29, 2021
scaladoc/test-source-links/dotty/tools/scaladoc/source-links/RemoteLinksTest.scala
Outdated
Show resolved
Hide resolved
griggt
reviewed
Jul 29, 2021
scaladoc/test-source-links/dotty/tools/scaladoc/source-links/RemoteLinksTest.scala
Outdated
Show resolved
Hide resolved
Sort files and properly handle end line
dwijnand
force-pushed
the
scaladoc/link-test-fixes
branch
from
16d4450 to
6efc512
Compare
dwijnand
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of the comments from #13196