Scaladoc: Fix regression with extension methods not being shown in searchbar #14779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error was introduced in 598b8d3 that made it so that some methods were unnecesarily ommited from the searching function.
pikinier20
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error was introduced in 598b8d3 that made it so that some methods were incorrectly omitted from the search bar. This was caused by mistakenly filtering members with defined inheritedFrom methods instead of the ones with empty.
m.inheritedFrom.isEmptybecamem.inheritedFrom.fold(false)(_.isSourceSuperclassHidden))but should have beenm.inheritedFrom.fold(true)(_.isSourceSuperclassHidden))- the intent was to also allow to search for inherited from hidden superclasses, but not exclusively, like it was done by mistake.Fixes #14778
https://scala3doc.virtuslab.com/pr-fix-searchbar-extensions/scala3/index.html