Backport "Attempt implicit search for old style implicit parameters in Application matchArgs" #20171
Conversation
…n Application matchArgs"
|
Really hope this will be backported - unblocking 3.3 on MUnit in turn unblocks several other libraries that have already moved on to LTS, and in turn unblocks Scala Native 0.5.0 upgrades (the chain is long, yeah) |
|
There might have been a reason why it was not backported into LTS yet. I've started the Open CB to check how it affects other projects. |
We've not found any new regressions in the Open CB related to this PR. The failing projects are either already on Scala 3.Next or were failing already on the LTS branch (last LTS nightly 3.3.4-RC1-bin-20240326-feeddb7-NIGHTLY) |
As there isn't an artifact for Scala 3 LTS that includes scala/scala3#20171 I gave it a try with 3.4.2-RC1 that already contains scala/scala3#19737 This PR shows that the only thing that changes is the message returned form the compiler and not changes to munit are needed once Scala 3 LTS with the fix gets released.
|
It seems this fell between the cracks. Is it still mergeable? |
|
It was backported in #20936 and released in 3.3.4 We must have missed this PR for manual backport, but we handled it based on the LTS backports queue |
5 participants
Backports #19737 to the LTS branch.
Fixes #19594
This prevents munit from updating to Scala 3.3.x: scalameta/munit#565