Skip to content

Backport "SimplePattern errors should now be recovered as wildcard instead of unimplemented expr" to 3.5.2 #21498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

Backport "SimplePattern errors should now be recovered as wildcard instead of unimplemented expr" to 3.5.2 #21498

merged 1 commit into from
Aug 28, 2024

Conversation

@WojciechMazur
Copy link
Contributor

Backports #21438 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]

@rochala @WojciechMazur
SimplePattern errors should now be recovered as wildcard instead of u…
74cfecf 
…nimplemented expr (#21438)

We should not emit more errors that came from our error recovery term
trees.

Previously, we've recovered those situations with unimplemented
expression term added in #19103
and before that it was just a `null`
[Cherry-picked f036195]
Base automatically changed from release-3.5.x-21404 to 3.5.x August 28, 2024 14:32
@WojciechMazur WojciechMazur merged commit 123ee63 into 3.5.x Aug 28, 2024
@WojciechMazur WojciechMazur deleted the release-3.5.x-21438 branch August 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WojciechMazur @rochala