Skip to content

Make subclasses of scala.quoted.Expr covariant #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2018
Merged

Make subclasses of scala.quoted.Expr covariant #4896

merged 1 commit into from
Aug 5, 2018

Conversation

@nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki mentioned this pull request Aug 5, 2018
Merged
Blaisorblade
Blaisorblade approved these changes Aug 5, 2018
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not 100% we need to, but if any downside shows up we can reconsider.

@Blaisorblade Blaisorblade merged commit 48a4daa into scala:master Aug 5, 2018
@Blaisorblade Blaisorblade deleted the fix-#4891 branch August 5, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Blaisorblade Blaisorblade Blaisorblade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Blaisorblade Blaisorblade

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolasstucki @Blaisorblade