Fix #7142: Detect scope extrusions in macros and run #8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#7142
branch
9 times, most recently
from
e556af7 to
63abf80
Compare
nicolasstucki
force-pushed
the
fix-#7142
branch
from
63abf80 to
7831691
Compare
anatoliykmetyuk
added a commit
to dotty-staging/sourcecode
that referenced
this pull request
Jan 17, 2020
In Scala 3, macro `mcr()` is expanded to: val macro$n = ... macro$n Where n is an ordinal. This commit accounts for this change. See scala/scala3#8000.
This comment has been minimized.
This comment has been minimized.
nicolasstucki
force-pushed
the
fix-#7142
branch
2 times, most recently
from
b959904 to
f1179cc
Compare
nicolasstucki
pushed a commit
to dotty-staging/sourcecode
that referenced
this pull request
Jan 20, 2020
In Scala 3, macro `mcr()` is expanded to: val macro$n = ... macro$n Where n is an ordinal. This commit accounts for this change. See scala/scala3#8000.
nicolasstucki
force-pushed
the
fix-#7142
branch
from
f1179cc to
42cd971
Compare
liufengyun
approved these changes
Jan 22, 2020
anatoliykmetyuk
added a commit
to dotty-staging/sourcecode
that referenced
this pull request
Apr 7, 2020
In Scala 3, macro `mcr()` is expanded to: val macro$n = ... macro$n Where n is an ordinal. This commit accounts for this change. See scala/scala3#8000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.