Skip to content

Conversation

@adpi2
Copy link
Member

@adpi2 adpi2 commented Jul 13, 2022

After discussion, it appears that exclusion of single modules is more useful than exclusion of entire projects, on all Scala versions, or entire scala versions, on all projects. The main argument is that we should publish all graphs, on all projects and all scala versions, except if there is a non-easy-to-solve problem on a module. In which case it is better to exclude this particular module rather than non publish the graph.

In this PR:

  • Rename the project to sbt-dependency-submission
  • Rename base-dir to working-directory
  • Remove the projects, scala-versions input
  • Add the modules-ignore input (plain text, no glob)
  • Log the names of all included and excluded modules
  • Remove sbt-plugin-version input. It is not needed, the action should always use the current version of the plugin.
  • Add on-resolve-failure input. Default is error, one can switch to warn to ignore the dependency resolution failures with warnings.

Tested in:

@adpi2 adpi2 force-pushed the modules-ignore branch 6 times, most recently from f491359 to f9d7d50 Compare July 14, 2022 12:37
@adpi2 adpi2 force-pushed the modules-ignore branch 2 times, most recently from 3ed233b to e6b1b6c Compare July 14, 2022 12:57
@adpi2 adpi2 marked this pull request as ready for review July 14, 2022 13:13
@adpi2 adpi2 merged commit 01793f4 into main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants