Skip to content

fix(DebugAdaptorPlugin): parsing envVars with edge cases #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

fix(DebugAdaptorPlugin): parsing envVars with edge cases #870

merged 2 commits into from
May 23, 2025

Conversation

@nedsociety
Copy link
Contributor

@nedsociety nedsociety commented May 14, 2025 •
edited
Loading

Currently we're observing an envvar parse bug in metals + sbt bsp mode:

  • an envvar whose value includes = is stripped of them
    • e.g., "ENV=ZGlkIHlvdSB0cnkgZGVjb2RpbmcgdGhpcz8=" loses = at the end
  • an envvar whose value is empty is omitted.
    • e.g., "ENV=" are not injected into the debuggee.

This PR tries to fix these issue.

Example:

image

@nedsociety nedsociety changed the title fix(ForkOption) parser to correctly handle an envVar ENV=VALUE=== fix(ForkOption): parser to correctly handle an envVar ENV=VALUE=== May 14, 2025
@nedsociety nedsociety changed the title fix(ForkOption): parser to correctly handle an envVar ENV=VALUE=== fix(DebugAdaptorPlugin): parser to correctly handle envVars with = at the end May 14, 2025
@nedsociety nedsociety changed the title fix(DebugAdaptorPlugin): parser to correctly handle envVars with = at the end fix(DebugAdaptorPlugin): parsing envVars correctly with = at the end May 14, 2025
@nedsociety nedsociety changed the title fix(DebugAdaptorPlugin): parsing envVars correctly with = at the end fix(DebugAdaptorPlugin): parsing envVars with edge cases May 14, 2025
@nedsociety
Copy link
Contributor Author

nedsociety commented May 23, 2025

@scalacenter Request for review as PR's getting stale for more than a week. Thanks.

@tgodzik
Copy link
Collaborator

tgodzik commented May 23, 2025

Sorry I missed the PR, looks like the CI is failing, could you take a look?

@nedsociety
Copy link
Contributor Author

nedsociety commented May 23, 2025 •
edited
Loading

Ah yes, this is one of the projects that I didn't actually try building it myself during debugging. Fixed.

tgodzik
tgodzik approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 07af403 into scalacenter:main May 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nedsociety @tgodzik