Skip to content

Revert "Found a bug in the codellama vllm model_len logic." #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Revert "Found a bug in the codellama vllm model_len logic." #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@
"mammoth-coder": {"max_model_len": 16384, "max_num_batched_tokens": 16384},
# Based on config here: https://huggingface.co/TIGER-Lab/MAmmoTH-Coder-7B/blob/main/config.json#L12
# Can also see 13B, 34B there too
"codellama": {"max_model_len": 16384, "max_num_batched_tokens": 16384},
"code-llama": {"max_model_len": 16384, "max_num_batched_tokens": 16384},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question on this Yunfeng: I wanted the models to be named codellama to be in keeping with the way that it's formatted for finetuning, why are we switching?

# Based on config here: https://huggingface.co/codellama/CodeLlama-7b-hf/blob/main/config.json#L12
# Can also see 13B, 34B there too. Note, codellama is one word.
# Can also see 13B, 34B there too
"llama-2": {"max_model_len": None, "max_num_batched_tokens": 4096},
"mistral": {"max_model_len": 8000, "max_num_batched_tokens": 8000},
}
Expand Down