Skip to content

Conversation

dmchoiboi
Copy link
Collaborator

@dmchoiboi dmchoiboi commented Oct 15, 2024

  • Update oai spec to remove strict flag default to workaround vllm incompatibilty
  • additional flags to set through API
  • fix handling vllm args false flags

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Test Plan and Usage Guide

Created llama-3-1-8b-instruct endpoint

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

…mpatibilty + additional flags to set through API

tool_call_parser: Optional[str] = Field(
None,
description="Tool call parser",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's tool call parser?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmchoiboi dmchoiboi merged commit ff971ea into main Oct 16, 2024
7 checks passed
@dmchoiboi dmchoiboi deleted the dmchoi/tool-use-fixes branch October 16, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants