Skip to content

Conversation

dmchoiboi
Copy link
Collaborator

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Support bearer token auth. This allows openai client to be used against llmengine with no additional headers

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

Copy link
Contributor

@seanshi-scale seanshi-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like it's fine to have basic auth take precedence over bearer token (esp for migration purposes), idk what the "right" order is but that's a whole other conversation

@dmchoiboi dmchoiboi merged commit 9233b9a into main Oct 24, 2024
7 checks passed
@dmchoiboi dmchoiboi deleted the dmchoi/bearer-auth branch October 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants