Skip to content

Conversation

dmchoiboi
Copy link
Collaborator

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Needed for graceful helm upgrade for environments that were deployed before we introduced alembic

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

Copy link
Contributor

@seanshi-scale seanshi-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does the script get run? i.e. do we have to manually run it or something like that?

@dmchoiboi
Copy link
Collaborator Author

dmchoiboi commented Oct 30, 2024

do we have to manually run it or something like that?

yes, it will need to be run manually before applying a new helm upgrade

@dmchoiboi dmchoiboi enabled auto-merge (squash) October 30, 2024 23:43
@dmchoiboi dmchoiboi merged commit 05f2ecc into main Oct 30, 2024
7 checks passed
@dmchoiboi dmchoiboi deleted the dmchoi/stamp-initial-schema branch October 30, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants