Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,10 @@ def _model_endpoint_entity_to_get_llm_model_endpoint_response(


def validate_model_name(model_name: str, inference_framework: LLMInferenceFramework) -> None:
# TODO: replace this logic to check if the model architecture is supported instead
if model_name not in _SUPPORTED_MODELS_BY_FRAMEWORK[inference_framework]:
raise ObjectHasInvalidValueException(
f"Model name {model_name} is not supported for inference framework {inference_framework}."
logger.warning(
f"Model name {model_name} may not be supported by inference framework {inference_framework}."
)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ aws ecr get-login-password --region us-west-2 | docker login --username AWS --pa
DOCKER_BUILDKIT=1 docker build \
--build-arg VLLM_VERSION=${VLLM_VERSION} \
--build-arg VLLM_BASE_REPO=${VLLM_BASE_REPO} \
-f Dockerfile.vllm \
-f ${DOCKERFILE} \
--target ${BUILD_TARGET} \
-t $IMAGE ${PROJECT_DIR}
docker push $IMAGE
35 changes: 0 additions & 35 deletions model-engine/tests/unit/domain/test_llm_use_cases.py
Original file line number Diff line number Diff line change
Expand Up @@ -704,41 +704,6 @@ async def test_create_model_endpoint_trt_llm_use_case_success(
)


@pytest.mark.asyncio
async def test_create_llm_model_endpoint_use_case_raises_invalid_value_exception(
test_api_key: str,
fake_model_bundle_repository,
fake_model_endpoint_service,
fake_docker_repository_image_always_exists,
fake_model_primitive_gateway,
fake_llm_artifact_gateway,
create_llm_model_endpoint_request_invalid_model_name: CreateLLMModelEndpointV1Request,
):
fake_model_endpoint_service.model_bundle_repository = fake_model_bundle_repository
bundle_use_case = CreateModelBundleV2UseCase(
model_bundle_repository=fake_model_bundle_repository,
docker_repository=fake_docker_repository_image_always_exists,
model_primitive_gateway=fake_model_primitive_gateway,
)
llm_bundle_use_case = CreateLLMModelBundleV1UseCase(
create_model_bundle_use_case=bundle_use_case,
model_bundle_repository=fake_model_bundle_repository,
llm_artifact_gateway=fake_llm_artifact_gateway,
docker_repository=fake_docker_repository_image_always_exists,
)
use_case = CreateLLMModelEndpointV1UseCase(
create_llm_model_bundle_use_case=llm_bundle_use_case,
model_endpoint_service=fake_model_endpoint_service,
docker_repository=fake_docker_repository_image_always_exists,
llm_artifact_gateway=fake_llm_artifact_gateway,
)
user = User(user_id=test_api_key, team_id=test_api_key, is_privileged_user=True)
with pytest.raises(ObjectHasInvalidValueException):
await use_case.execute(
user=user, request=create_llm_model_endpoint_request_invalid_model_name
)


@pytest.mark.asyncio
async def test_create_llm_model_endpoint_use_case_quantization_exception(
test_api_key: str,
Expand Down