-
Notifications
You must be signed in to change notification settings - Fork 24
fix(crypto): dict object error in --input processing #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update refactors the construction of Changes
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
30126bb
to
d9b7fbe
Compare
d9b7fbe
to
4f64b3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
12-15
: Use “Fixed” section & improve wordingUnder Keep a Changelog, bug patches belong in a
### Fixed
section, not### Added
.
Also capitalise “PURL” and use the past-tense pattern used elsewhere.-### Added -- Fix purls parsing on `crypto` subcommand +### Fixed +- Fixed PURL parsing in `crypto` subcommand
594-595
: Minor ordering nitFor long-term maintainability, keep the reference list sorted chronologically (newest on top).
Consider moving the two new definitions directly under the[1.28.0]
entry instead of appending after much older blocks, to prevent future merge conflicts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md
(2 hunks)src/scanoss/__init__.py
(1 hunks)src/scanoss/cryptography.py
(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/scanoss/init.py
🚧 Files skipped from review as they are similar to previous changes (1)
- src/scanoss/cryptography.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
This PR fixes a bug in the crypto command when using --input with JSON files.
Problem:
When running
scanoss-py crypto algorithms --key $SC_KEY --input purls.json
, users were getting the error:Testing:
After this fix, the crypto command works correctly with JSON input files like:
Summary by CodeRabbit