Skip to content

Conversation

isasmendiagus
Copy link
Contributor

@isasmendiagus isasmendiagus commented Jul 10, 2025

This PR fixes a bug in the crypto command when using --input with JSON files.

Problem:

When running scanoss-py crypto algorithms --key $SC_KEY --input purls.json, users were getting the error:

 'dict' object has no attribute 'split'. 

Testing:

After this fix, the crypto command works correctly with JSON input files like:

{
  "purls": [
    {"purl": "pkg:github/scanoss/[email protected]"}
  ]
}

Summary by CodeRabbit

  • Bug Fixes
    • Fixed parsing of package URLs (PURLs) in the cryptography-related command to ensure correct handling of version requirements.

Copy link

coderabbitai bot commented Jul 10, 2025

Walkthrough

The update refactors the construction of purls_with_requirement in CryptographyConfig.__post_init__ to unify handling of PURLs with optional version requirements. It adds a helper method _remove_version_from_purl in Cryptography and revises _build_purls_request to separate the PURL string from its version requirement explicitly.

Changes

File Change Summary
src/scanoss/cryptography.py Refactored CryptographyConfig.__post_init__ to consolidate PURL and requirement handling into a single loop. Added _remove_version_from_purl method. Updated _build_purls_request to separate PURL and version requirement fields.
CHANGELOG.md Added patch version 1.28.1 with fix for parsing package URLs in the crypto subcommand and updated version comparison links.
src/scanoss/init.py Updated version string from '1.28.0' to '1.28.1'.

Possibly related PRs

Suggested reviewers

  • eeisegn

Poem

A hop, a skip, a tidy line,
PURLs and versions now align.
Strings and versions split apart,
Clearer code, a happy heart!
🐇✨🥕

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@isasmendiagus isasmendiagus force-pushed the fix/SP-2900/input-json-crypto-subcommand branch from 30126bb to d9b7fbe Compare July 10, 2025 15:27
@isasmendiagus isasmendiagus force-pushed the fix/SP-2900/input-json-crypto-subcommand branch from d9b7fbe to 4f64b3c Compare July 10, 2025 15:28
@isasmendiagus isasmendiagus merged commit e34a56e into main Jul 10, 2025
3 of 4 checks passed
@isasmendiagus isasmendiagus deleted the fix/SP-2900/input-json-crypto-subcommand branch July 10, 2025 15:31
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
CHANGELOG.md (2)

12-15: Use “Fixed” section & improve wording

Under Keep a Changelog, bug patches belong in a ### Fixed section, not ### Added.
Also capitalise “PURL” and use the past-tense pattern used elsewhere.

-### Added
-- Fix purls parsing on `crypto` subcommand
+### Fixed
+- Fixed PURL parsing in `crypto` subcommand

594-595: Minor ordering nit

For long-term maintainability, keep the reference list sorted chronologically (newest on top).
Consider moving the two new definitions directly under the [1.28.0] entry instead of appending after much older blocks, to prevent future merge conflicts.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 30126bb and 4f64b3c.

📒 Files selected for processing (3)
  • CHANGELOG.md (2 hunks)
  • src/scanoss/__init__.py (1 hunks)
  • src/scanoss/cryptography.py (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/scanoss/init.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/scanoss/cryptography.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants