Skip to content

bug:SP-2020 Fixes undeclared component policy check summary #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025
Merged

bug:SP-2020 Fixes undeclared component policy check summary #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21adc8a
bug:SP-2020 Fixes undeclared component policy check summary
agustingroh Jan 6, 2025
74b718b
Refactor on _get_summary function
agustingroh Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ docs/build
!tests/data/*.json
!docs/source/_static/*.json
!scanoss-settings-schema.json
.DS_Store
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Upcoming changes...

## [1.19.1] - 2025-01-06
### Fixed
- Fixed undeclared components inspection

## [1.19.0] - 2024-11-20
### Fixed
- Check if legacy sbom file before post processing
Expand Down Expand Up @@ -418,4 +422,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[1.17.5]: https://github.com/scanoss/scanoss.py/compare/v1.17.4...v1.17.5
[1.18.0]: https://github.com/scanoss/scanoss.py/compare/v1.17.5...v1.18.0
[1.18.1]: https://github.com/scanoss/scanoss.py/compare/v1.18.0...v1.18.1
[1.19.0]: https://github.com/scanoss/scanoss.py/compare/v1.18.1...v1.19.0
[1.19.0]: https://github.com/scanoss/scanoss.py/compare/v1.18.1...v1.19.0
[1.19.1]: https://github.com/scanoss/scanoss.py/compare/v1.19.0...v1.19.1
2 changes: 1 addition & 1 deletion src/scanoss/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
THE SOFTWARE.
"""

__version__ = "1.19.0"
__version__ = "1.19.1"
8 changes: 4 additions & 4 deletions src/scanoss/inspection/undeclared_component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ def _get_summary(self, components: list) -> str:
if self.sbom_format == 'settings':
summary += (f'Add the following snippet into your `scanoss.json` file\n'
f'\n```json\n{json.dumps(self._generate_scanoss_file(components), indent=2)}\n```\n')
return summary

summary += (f'Add the following snippet into your `sbom.json` file\n'
else:
summary += (f'Add the following snippet into your `sbom.json` file\n'
f'\n```json\n{json.dumps(self._generate_sbom_file(components), indent=2)}\n```\n')
return summary

return summary

def _json(self, components: list) -> Dict[str, Any]:
"""
Expand Down
Loading