chore: rework versioning #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/chore/reworkversion
branch
4 times, most recently
from
c2805c7 to
c5422eb
Compare
jcfr
reviewed
Mar 29, 2024
jcfr
reviewed
Mar 29, 2024
jcfr
reviewed
Mar 29, 2024
jcfr
reviewed
Mar 29, 2024
jcfr
reviewed
Mar 29, 2024
jcfr
reviewed
Mar 29, 2024
jcfr
reviewed
Mar 30, 2024
This was referenced Apr 5, 2024
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/chore/reworkversion
branch
from
f1ee141 to
099bfe2
Compare
henryiii
commented
Apr 5, 2024
| # The full version, including alpha/beta/rc tags. | ||
| release = version | ||
| with pyproject.open('rb') as f: | ||
| release = tomllib.load(f)["project"]["version"] |
There was a problem hiding this comment.
This fixes the docs build, which has been broken for quite a while.
|
Discussion note: Add pyproject.toml to the nox |
Thanks! I'd already forgotten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework versioning to come from pyproject.toml.
Other cleanups.