dev in conda #8
dev in conda #8
Conversation
|
closes issue aghast #28 Opps... CI / pre-commit failing... |
|
@henryiii Could you help me with this CI problem? I don't know why I got this. |
|
@henryiii Anything else to change? |
|
Btw, should this -- conda dev support -- be added for boost-histogram? |
No, let's keep boost-histogram simple. And it's really only a special case for the 2-3 people who actually download the repository - for the vast majority of users, they will be running environment.yml is special, since mybinder.org picks it up; so that is always the requirements to run the example notebooks. |
Co-Authored-By: Henry Schreiner <[email protected]>
Co-Authored-By: Henry Schreiner <[email protected]>
|
@henryiii Agreed all your commits above. |
dev-environment.yml
Outdated
| - pip >=18 | ||
| - root >=6.20.0 | ||
| - pip: | ||
| - -r dev-requirements.txt |
There was a problem hiding this comment.
| - -r dev-requirements.txt |
This environment should have conda dependencies, not PyPI ones. dev-requirements is PyPI.
There was a problem hiding this comment.
The only exception is if requirements are only available through pip, but I don't think we have any of those.
There was a problem hiding this comment.
I agreed your commits.
But how do we install them, we need to pip install -r dev-requirements.txt in the conda environment manually?
There was a problem hiding this comment.
Mean that we need to
pip install -r dev-requirements.txtin the conda environment manually?
If so, I add a this line to CONTRIBUTING.md instructions as you can see in a57d828
There was a problem hiding this comment.
No. PyPI and Conda are different. You have to list the packages again here in this file if you want them - they aren't even guaranteed to have the same Conda name as PyPI name (though often they do).
There was a problem hiding this comment.
they aren't even guaranteed to have the same Conda name as PyPI name (though often they do)
👍 You are right! And some even do not have conda installation like mplhep.
There was a problem hiding this comment.
No dev-requirements.txt anymore, PTAL.
|
@henryiii LGTM, able to merge? I need to make some changes to aghast (I made pip dev-requriement.txt for it in env YAML previously, it should be in conda style). |
|
This should be merged, not sure why it's "open". |
2 participants
No description provided.