MAINT: Use the latest stable kokkos/mdspan version (2001002)
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I expect to see some windows test failures here as well. Should we ignore them, or ... ? |
Member
|
We've been ignoring them so far, yep |
Collaborator
|
Thanks for figuring that out @jorenham! Much appreciated. |
JaRoSchm
pushed a commit
to JaRoSchm/xsf
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
mdspan.hppseems to be causing build failures on windows, as can be seen in #62.This upgrades
kokkos/mdspanto the latest stable version (2001002) (currently the latest commit of the "stable" branch).I used their
make_single_header.pyscript to bundle it, and updatedMDSPAN_IMPL_STANDARD_NAMESPACEandMDSPAN_IMPL_PROPOSED_NAMESPACEto match the current situation (instead ofKokkosandExperimental, respectively).