Can't change value from '' to 'foo'

[fabiospampinato]

This line looks wrong to me, why are we checking for this.props.value? By doing this I can't set a truthy value if the previous one was falsy.

[scniro]

Thanks for opening this up. Can you please explain a bit more? I don't fully understand your issue here. If there is a value prop, I set the value in the codemirror instance. I'll be happy to check this out but I just need a little more explanation.

[fabiospampinato]

The only thing that needs to be checked is if the current value and the next value are equal or not, which is what hydrated is all about.

The line I referenced to in the first post is also checking if the current value is truthy, which it shouldn't really care about. For instance if the current value is '' (an empty string), then if ( this.props.value ) will be false, and even if the new value is something like 'foo', this.editor.setValue won't be called.

[scniro]

@fabiospampinato makes sense. I'll get a fix up published tomorrow. Will post back here with an update. Thanks!

[scniro]

@fabiospampinato 0.0.13 pushed up to npm with a fix for this seen in this diff. Please let me know if this resolves your issue. Thanks!

[fabiospampinato]

That fixes the issue, thanks!