Skip to content

Fix Cobertura unit test #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix Cobertura unit test #510

merged 1 commit into from
Oct 18, 2022

Conversation

dalbani
Copy link
Contributor

@dalbani dalbani commented Oct 17, 2022 •
edited
Loading

The suggested changes seem to fix the issue — at least it does here locally.
Although I don't understand why the issue cropped up only now 🤔

@dalbani dalbani changed the title [WIP] Fix Cobertura unit test Fix Cobertura unit test Oct 17, 2022
ckipp01
ckipp01 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, great catch. Thanks for the fix! I'm pretty sure this popped up now because upstream Scala is now using a new version of scala-xml which has stricter parsing. Which makes sense now that it'd fail on http. Thanks again!

@ckipp01 ckipp01 merged commit 0e9dde4 into scoverage:main Oct 18, 2022
@dalbani dalbani deleted the fix-cobertura-test branch October 18, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalbani @ckipp01