[UEPR-314] Replace magic numbers and hardcoded strings #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KManolov3
approved these changes
Oct 1, 2025
adzhindzhi
merged commit 65628f9
into
scratchfoundation:UEPR-282-face-sensing
6 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
UEPR-314
Proposed Changes
TILT_THRESHOLDANDdefaultPosas constantsNote: The ticket suggests replacing numeric face part IDs with descriptive string constants. Since these IDs come from TensorFlow keypoints, we would still need a mapping between the two. Using the enum already makes the code clear enough, so this change is no longer necessary.
Reason for Changes
Improve readability and maintainability of the face sensing codebase