Request a toolbox refresh after switching between tabs to fix #4561 #4563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Reason for Changes
Explain why these changes should be made
Make sure to enqueue a toolbox update any time the workspace is refreshed, so that the toolbox can continue updating.
Test Coverage
Please show how you have added tests to cover your changes
Added an integration test for this case.
/cc @picklesrus sigh... I think this basically brings us full-circle toolbox update-wise, with the one benefit that because we are enqueuing instead of updating directly, we avoid a couple cases of double updating, because refreshing the workspace apparently cannot happen without a corresponding toolbox update because it then forever disables the toolbox from refreshing. Oh also we now have several more integration tests to cover the toolbox not updating. So hopefully we can do some real refactoring now that we have tests.