APIs for getting and setting variable values #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchadha
reviewed
Jun 5, 2018
src/virtual-machine.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Set a target variables value if it exists. Return whether it succeeded. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
reviewed
Jun 5, 2018
src/virtual-machine.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Set a target variables value if it exists. Return whether it succeeded. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kchadha
reviewed
Jun 5, 2018
kchadha
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few top-level APIs for getting/setting variable values.
The match the "prototype" that was made in the GUI, which can now be migrated to use these methods.
Additionally, these tests uncovered a bug, which was fixed :)
Fixes #1145