-
Notifications
You must be signed in to change notification settings - Fork 284
fix: add EIP-3607 check in L1 messages #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the control flow in the Changes
Sequence Diagram(s)sequenceDiagram
participant S as StateTransition
participant T as Transaction
participant D as Sender Details
S->>T: Receive transaction request
alt Transaction is not fake
S->>D: Check sender's code length and delegation
alt Sender has code and not delegated
D-->>S: Return error ("Not an EOA")
S->>T: Abort processing
else
D-->>S: Confirm valid EOA
S->>T: Proceed with nonce and L1 message handling
end
else
S->>T: Skip EOA checks and process normally
end
Suggested labels
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Péter Garamvölgyi <[email protected]>
1. Purpose or design rationale of this PR
Make it consistent with
revmside implementations.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit