Skip to content

Conversation

@Thegaram
Copy link

1. Purpose or design rationale of this PR

Limit the number of inputs to the ecPairing precompile to be not more than 4.

  • To support dynamic pairing length in the zkEVM, significant effort is required. Therefore, we have decided to focus on prioritized tasks at this time.
  • The number of pairs for groth16 is 4 and for plonk it is 2. We believe that supporting 4 pairs will satisfy almost all use cases. The only known exception is groth16 batch verification, which is mostly a gas optimization and not a critical requirement.

Detailed rationale: Slack

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram requested review from icemelon and lispc June 28, 2023 17:46
icemelon
icemelon previously approved these changes Jun 28, 2023
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment.

@Thegaram Thegaram merged commit 8c141eb into develop Jun 29, 2023
@Thegaram Thegaram deleted the limit-ecpairing-to-4-inputs branch June 29, 2023 07:22
@Thegaram Thegaram mentioned this pull request Jun 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants