This repository was archived by the owner on Apr 18, 2025. It is now read-only.
feat: stack reconstruct #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsing
force-pushed
the
feat/stack-reconstruct
branch
5 times, most recently
from
9454828 to
5a3fdc6
Compare
lightsing
force-pushed
the
feat/stack-reconstruct
branch
4 times, most recently
from
c356c4c to
737d959
Compare
|
oh this can be next PR. Add a stack_head to trace struct. |
lightsing
force-pushed
the
feat/stack-reconstruct
branch
7 times, most recently
from
9dd299b to
0052b3b
Compare
lightsing
force-pushed
the
feat/stack-reconstruct
branch
from
f6dd701 to
2e52052
Compare
lightsing
force-pushed
the
feat/stack-reconstruct
branch
from
2e52052 to
273baa2
Compare
lispc
reviewed
Oct 17, 2023
lightsing
force-pushed
the
feat/stack-reconstruct
branch
2 times, most recently
from
d9495da to
8784bcc
Compare
|
looks good to me. I will run testool later today then merge it. |
|
@lightsing a lot failures. I would suggest check these failed precompiles like https://circuit-release.s3.us-west-2.amazonaws.com/testool/nightly.1706707610.0cecef0.html |
|
default suit: https://circuit-release.s3.us-west-2.amazonaws.com/testool/default.1707280178.9aef6df.html |
lispc
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CHECK_MEM_STRICTchanges toCHECK_MEM_STACK_LEVEL