Skip to content

Conversation

@scwf
Copy link
Owner

@scwf scwf commented Dec 4, 2014

@scwf
Copy link
Owner Author

scwf commented Dec 4, 2014

bugs:

  1. sbt compile will get error while mvn is ok
    sbt compile error:
    impossible to get artifacts when data has not been loaded.
    error java.lang.IllegalStateException: impossible to get artifacts when data has not been loaded. IvyNode = junit#junit;4.10

  2. sbt test do not recognize MiniHBaseCluster

todos:

  1. unit test
  2. integrate optimizations
  3. load
  4. metastore

@scwf
Copy link
Owner Author

scwf commented Dec 4, 2014

Updated: fix bug1 by excluding junit in hbase artifacts.

@yzhou2001
Copy link

@scwf : The destination of this PR( and #15) is not Huawei-Spark:hbase, but "master" (for #15 swcf:master") instead. Please double check and confirm. Thanks!

@scwf
Copy link
Owner Author

scwf commented Dec 5, 2014

Hi @yzhou2001, scwf:master is same with apache:master, so i make a PR to it.
And Huawei-Spark:hbase now is conflict with apache:master

@yzhou2001
Copy link

Ok. Then I’ll update our repo to the master. After that, though, you’ll need to point your PR’s destination to our repo of Huawei-Spark:hbase. If you can do that beforehand, I’d appreciate.

Thanks,

Yan

From: wangfei [mailto:[email protected]]
Sent: Thursday, December 04, 2014 5:19 PM
To: scwf/spark
Cc: Yan Zhou.sc
Subject: Re: [spark] More clean one for review (#16)

Hi @yzhou2001https://github.com/yzhou2001, scwf:master is same with apache:master, so i make a PR to it.
And Huawei-Spark:hbase now is conflict with apache:master


Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-65733537.

@yzhou2001
Copy link

Ok. Then I’ll update our repo to the master. After that, though, you’ll need to point your PR’s destination to our repo of Huawei-Spark:hbase. If you can do that beforehand, I’d appreciate.

@scwf
Copy link
Owner Author

scwf commented Dec 5, 2014

@yzhou2001, actually i have updated the Huawei-Spark:hbase with apache:master, then work with it and finally come to this branch. So i suggest to make this PR our final one to contribute to community, now we can add features/bugsfix from Huawei-Spark:hbase to this branch to make it perfect to contribute.

And note:
In this branch, there is no hbasesqlcontext, i add a hbase package in sql/core in which using data source api(just like parquet has done).

@scwf
Copy link
Owner Author

scwf commented Dec 5, 2014

I will push this branch to Huawei-Spark. So you all have access to it.

@scwf scwf closed this Dec 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants