logger: restore Logger and logging callback on integ. test teardown #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When integration test gets constructed, it can set global `cb_` and `data_` to temporaries. After the test finishes and temporaries are destroyed, the next tests ctor may try to refer to them (before it sets the globals by itself). This happened in the ctor of `Random`, which logged a message in case of failure. Sometimes this manifested as segfault, sometimes as a deadlock. This fix restores the old logger values on test teardown - most likely to stderr. Fixes datastax#13
jul-stas
force-pushed
the
integ-tests-correct-fix
branch
from
65385e7 to
e7d1193
Compare
kbr-
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integration test gets constructed, it can set global
cb_anddata_to temporaries. After the test finishes and temporaries aredestroyed, the next tests ctor may try to refer to them (before it
sets the globals by itself).
This happened in the ctor of
Random, which logged a message incase of failure. Sometimes this manifested as segfault, sometimes
as a deadlock. This fix restores the old logger values on test teardown -
Fixes #13