Skip to content

Conversation

@jul-stas
Copy link

These changes are mostly about naming, updating licenses and pointing to our websites.
Tested on Centos 7 and Ubuntu 18.04.

Copy link

@penberg penberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's see if we can also get @syuu1228 to review this.

@sitano
Copy link

sitano commented Jan 12, 2021

@jul-stas on Debian it is missing zlib-dev dependency for build that is required from: scylla-cpp-driver-2.15.2/src/third_party/minizip/unzip.c:75:10. so file it self does not depend on zlib tho.

@jul-stas
Copy link
Author

@jul-stas on Debian it is missing zlib-dev dependency...

Good catch. Luckily, the installation guides for cpp-driver do care about zlib, so nobody noticed that for years (?)

@sitano
Copy link

sitano commented Jan 12, 2021

@jul-stas overall I built it well on Debian docker and it installed fine. So I guess its overall well. There are warns from the packaging linter that can be fixed. And also I would suggest checking the thing with pbuilder-dist. I am sorry I can't invest more into that.

@jul-stas
Copy link
Author

jul-stas commented Jan 13, 2021

@jul-stas on Debian it is missing zlib-dev dependency

Now I see: zlib dependency can be toggled off in cmake. So it can stay as it is now.

@jul-stas jul-stas merged commit 1b2957f into scylladb:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants