Make sure all queries to system.local uses WHERE clause #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full scan requests are executed slower even if there is only one record
|
Why do we need this? It's only tests / examples. |
Sure, why not fix them too? |
It makes sense to have proper use of ScyllaDB in all places, including tests and especially examples. |
muzarski
approved these changes
Feb 16, 2025
Merged
muzarski
added a commit
to muzarski/cpp-rust-driver
that referenced
this pull request
May 5, 2025
1. The test is skipped for Scylla (Scylla does not emit such warning) - I think it's better to enable it, and skip it during runtime, rather than disabling it at all. 2. The test is adjusted so the WHERE clause is removed (to trigger the warning). The WHERE clause was added here: scylladb#221
muzarski
added a commit
to muzarski/cpp-rust-driver
that referenced
this pull request
May 6, 2025
1. The test is skipped for Scylla (Scylla does not emit such warning) - I think it's better to enable it, and skip it during runtime, rather than disabling it at all. 2. The test is adjusted so the WHERE clause is removed (to trigger the warning). The WHERE clause was added here: scylladb#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full scan requests are executed slower even if there is only one record
Fixes: #220
Pre-review checklist
I have implemented Rust unit tests for the features/changes introduced.I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.