Enable some of the ServerSideFailure tests
#294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk
reviewed
May 5, 2025
1. The test is skipped for Scylla (Scylla does not emit such warning) - I think it's better to enable it, and skip it during runtime, rather than disabling it at all. 2. The test is adjusted so the WHERE clause is removed (to trigger the warning). The WHERE clause was added here: scylladb#221
This test works for both Cassandra and Scylla - no adjustments are required.
It will be now more clear which tests are failing and should possibly be addressed in the future. The disabled tests from this suite are using UDFs, which are hidden behind unstable feature in Scylla. We may want to enable them in the future, but for now let's leave them disabled.
muzarski
force-pushed
the
server-side-failure-it
branch
from
46a9ac4 to
03d3517
Compare
muzarski
changed the title
ServerSideFailure testsServerSideFailure tests
Lorak-mmk
approved these changes
May 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #132
cpp-driver does not expose API to inspect the warnings emitted by Scylla. Instead, it logs the warnings at
WARNlevel.In this PR, we also enable non-UDF
ServerSideFailuretests:ErrorTableAlreadyExists-> this works without any adjustmentsWarning-> this works only for Cassandra. It's because Scylla does not emit similar warning. I decided to enable the test for Scylla as well, but skip it during runtime (with proper message, informing why the test is skipped).Remaining two tests from this suite are using UDFs. For now, I'm leaving them disabled for both Scylla and Cassandra. In the future, we might want to enable UDF Scylla feature and run those tests.
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced..github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.