Skip to content

Fixing issue when skipped exception is being treated as a failed one. #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

Fixing issue when skipped exception is being treated as a failed one. #762

merged 1 commit into from
Nov 12, 2025

Conversation

@nikagra
Copy link

@nikagra nikagra commented Nov 12, 2025 •
edited
Loading

Fixing #761:

  • Handling SkipException in beforeInvocation and not rethrowing it
  • Manually setting test result to SKIP
  • Checking annotation conditions before setting up CCM in beforeTestClass method

@nikagra nikagra requested a review from dkropachev November 12, 2025 11:33
@nikagra nikagra self-assigned this Nov 12, 2025
@dkropachev dkropachev merged commit 924339a into scylladb:scylla-3.x Nov 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkropachev dkropachev dkropachev approved these changes

Assignees

@nikagra nikagra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikagra @dkropachev